Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split compiler and core #18683

Closed
wants to merge 3 commits into from
Closed

Split compiler and core #18683

wants to merge 3 commits into from

Conversation

tbosch
Copy link
Contributor

@tbosch tbosch commented Aug 14, 2017 •
edited

Note: The first 4 commits are from #18720

@tbosch tbosch added area: core Issues related to the framework runtime state: WIP refactoring Issue that involves refactoring or code-cleanup labels Aug 14, 2017
@mary-poppins
Copy link

You can preview 1e57ea0 at https://pr18683-1e57ea0.ngbuilds.io/.

@tbosch tbosch changed the title WIP: Split compiler and core Split compiler and core Aug 16, 2017
@mary-poppins
Copy link

You can preview 0aefd15 at https://pr18683-0aefd15.ngbuilds.io/.

@mary-poppins
Copy link

You can preview f422a63 at https://pr18683-f422a63.ngbuilds.io/.

chuckjaz
chuckjaz suggested changes Aug 16, 2017
View reviewed changes
packages/compiler/src/aot/static_reflector.ts Outdated
this._registerDecoratorOrConstructor(
this.findDeclaration(ANGULAR_CORE, 'Component'), Component);
this._registerDecoratorOrConstructor(this.findDeclaration(ANGULAR_CORE, 'NgModule'), NgModule);
this._registerDecoratorOrConstructor(MetadataIdentifier.Host, createHost);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline, I don't believe MetadataIdentifer is required.

packages/platform-browser-dynamic/src/compiler_reflector.ts
@@ -0,0 +1,149 @@
/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider moving the reflect_metadata requirement to this module so we no longer require it in compiler.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to postpone this to another PR...

@mary-poppins
Copy link

You can preview c1e5781 at https://pr18683-c1e5781.ngbuilds.io/.

@tbosch tbosch removed the state: WIP label Aug 16, 2017
@mary-poppins
Copy link

You can preview 20d14e2 at https://pr18683-20d14e2.ngbuilds.io/.

@mary-poppins
Copy link

You can preview b4bc466 at https://pr18683-b4bc466.ngbuilds.io/.

@tbosch
fix(tsc-wrapped): make test.sh tools run the tsc-wrapped tests again
e6f30f4
@tbosch
refactor(compiler): drop typings tests for TypeScript 2.1
51fa6bb
@tbosch
refactor(compiler): split compiler and core
40754da 
After this, neither @angular/compiler nor @angular/comnpiler-cli depend
on @angular/core.

This add a duplication of some interfaces and enums which is stored
in @angular/compiler/src/core.ts

BREAKING CHANGE:
- `@angular/platform-server` now additionally depends on
  `@angular/platform-browser-dynamic` as a peer dependency.
@tbosch
Copy link
Contributor Author

tbosch commented Aug 16, 2017

Note: This was already green, CI only runs because of another rebase.

@mary-poppins
Copy link

You can preview 40754da at https://pr18683-40754da.ngbuilds.io/.

@tbosch tbosch added the action: merge The PR is ready for merge by the caretaker label Aug 16, 2017
@tbosch tbosch mentioned this pull request Aug 16, 2017
Closed
mhevery pushed a commit that referenced this pull request Aug 17, 2017
@tbosch @mhevery
fix(tsc-wrapped): make test.sh tools run the tsc-wrapped tests again (
2da45e6 
#18683)
mhevery pushed a commit that referenced this pull request Aug 17, 2017
@tbosch @mhevery
refactor(compiler): drop typings tests for TypeScript 2.1 (#18683)
a0ca01d
@mhevery mhevery closed this in 0cc77b4 Aug 17, 2017
@mhevery mhevery added the target: major This PR is targeted for the next major release label Aug 17, 2017
@tbosch tbosch deleted the compiler_no_core branch August 18, 2017 14:33
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhevery mhevery mhevery approved these changes

@chuckjaz chuckjaz chuckjaz approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes refactoring Issue that involves refactoring or code-cleanup target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tbosch @mary-poppins @mhevery @chuckjaz @googlebot